- Notifications
You must be signed in to change notification settings - Fork950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add support for custom protocol with coursier#6375
Open
MasseGuillaume wants to merge1 commit intosbt:developChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedMar 9, 2021
11c1408 to2f855d2Compare2f855d2 to5ffc6bcCompareIs there anything that speaks against this? I'd really like to have this 🙂 |
What is blocking this? It would be of great help for us. |
⬆️ 🙏 |
I think this PR should be on top of 1.9.x branch, since develop branch is for sbt 2.x. |
rolang commentedFeb 24, 2024
It seems to be possible to set it via csrConfiguration:= csrConfiguration.value.withProtocolHandlerDependencies(Seq("org.example"%"google-artifact-repository-coursier"%"0.1.0")) |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In coursier, you can handle custom protocols by defining a protocol handler:
https://get-coursier.io/docs/2.0.10/extra.html#extra-protocols
https://github.com/coursier/coursier/blob/ce251d0288bf029e4eeb8700e8990178559a005d/modules/tests/jvm/src/test/scala/coursier/cache/protocol/TestprotocolHandler.scala
I'm currently implementing support for Google Artifact Resitory:
coursier/coursier#1987 (comment)
When dealing with artifact with protocol
artifactregistryI need to have a plugin available in the classpath. Since lmcoursier is in the sbt launcher classpath, it's not available by addinglibraryDependencies += ...inproject/plugins.sbtlike you would do for an sbt plugin. Therefore, I propose a way to explicitly declare the artifacts you need to handle the protocol handling.Users of custom protocol can now specify dependencies to their handler via this sbt setting:
Depends oncoursier/sbt-coursier#327