Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Fix mnle tests, MCMC init pbar, sir batch size.#1410

Merged
janfb merged 5 commits intomainfromfix-mnle-tests-and-example
Mar 5, 2025

Conversation

janfb
Copy link
Contributor

a couple of fixes for MNLE tests.

  • test mnle with conditions only for 1D discrete
  • fix vectorized evaluation ofBinomialGammaPotential
  • fixsir init function
  • add pbar for sequential MCMC inits in general

@codecovCodecov
Copy link

codecovbot commentedFeb 26, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.18%. Comparing base(dd4aef7) to head(e6c56be).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@##             main    #1410       +/-   ##===========================================- Coverage   89.20%   78.18%   -11.03%===========================================  Files         119      119                 Lines        8877     8916       +39     ===========================================- Hits         7919     6971      -948- Misses        958     1945      +987
FlagCoverage Δ
unittests78.18% <100.00%> (-11.03%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
sbi/inference/posteriors/mcmc_posterior.py83.58% <100.00%> (-2.57%)⬇️
sbi/samplers/importance/sir.py100.00% <100.00%> (ø)

... and37 files with indirect coverage changes

@janfbjanfb self-assigned thisFeb 27, 2025
Copy link
Contributor

@manuelgloecklermanuelgloeckler left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for fixing this!

The change in SIR is the bug fix, right?

Otherwise I suppose the most notebook changes are clean up to remove the warnings? If not I would remove them from the PR.

janfb reacted with thumbs up emoji
@janfbjanfb merged commit6e9a309 intomainMar 5, 2025
6 of 7 checks passed
@janfbjanfb deleted the fix-mnle-tests-and-example branchMarch 5, 2025 09:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@manuelgloecklermanuelgloecklermanuelgloeckler approved these changes

@michaeldeistlermichaeldeistlerAwaiting requested review from michaeldeistler

Assignees

@janfbjanfb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@janfb@manuelgloeckler
[8]ページ先頭
©2009-2025 Movatter.jp