Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Drop python3.8 and torch1.12; update dependencies#1233

Merged
janfb merged 2 commits intomainfromfix-tests
Aug 27, 2024
Merged

Conversation

janfb
Copy link
Contributor

@janfbjanfb commentedAug 26, 2024•
edited
Loading

  • fix tests
  • update deps

fixes#1229
fixes#1189
fixes#1150

@janfbjanfbforce-pushed thefix-tests branch 2 times, most recently from3e9e71a to6f84e6fCompareAugust 26, 2024 07:32
@codecovCodecov
Copy link

codecovbot commentedAug 26, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base(b3254ed) to head(ad51ede).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #1233      +/-   ##==========================================- Coverage   85.44%   85.35%   -0.09%==========================================  Files         101      101                Lines        7941     7956      +15     ==========================================+ Hits         6785     6791       +6- Misses       1156     1165       +9
FlagCoverage Δ
unittests85.35% <100.00%> (-0.09%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
sbi/analysis/plot.py70.54% <100.00%> (+0.02%)⬆️

... and2 files with indirect coverage changes

@janfb
Copy link
ContributorAuthor

janfb commentedAug 26, 2024•
edited
Loading

TODO:

  • generating the video in05_conditional_distributions tutorial throws an error:RuntimeError: Requested MovieWriter (ffmpeg) not available. add to dependencies? Or make test "local"
  • type checks failing plotting functions.

Copy link
Contributor

@michaeldeistlermichaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, thanks! I would suggest we add the MovieWriter to dev dependencies.

@janfbjanfbforce-pushed thefix-tests branch 2 times, most recently froma1376d9 to2a181aaCompareAugust 26, 2024 13:57
- add movie writer to dev deps- downgrade scipy to enable py3.9 support
@janfbjanfb merged commit9648aff intomainAug 27, 2024
7 checks passed
@janfbjanfb deleted the fix-tests branchAugust 27, 2024 09:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@michaeldeistlermichaeldeistlermichaeldeistler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@janfb@michaeldeistler
[8]ページ先頭
©2009-2025 Movatter.jp