- Notifications
You must be signed in to change notification settings - Fork180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
MTN better split the linting process from the CI/CD workflow#1164
Conversation
tomMoral commentedJun 6, 2024
- Separate workflow for the linting.
- Move pyright in dedicated process to avoid failing the test on type checks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #1164 +/- ##===========================================- Coverage 83.08% 72.94% -10.14%=========================================== Files 92 93 +1 Lines 7259 7371 +112 ===========================================- Hits 6031 5377 -654- Misses 1228 1994 +766
Flags with carried forward coverage won't be shown.Click here to find out more. |
This is part of the changes that were proposed in#1008 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great, this makes sense, thanks! I added one question.
Yes, pyright is failing atm, see#1162 . Probably due to a pyright update? But certainly unrelated to this branch.
* Base estimator class* MTN: split linting process from the CI/CD workflow (#1164)* Apply suggestions from code reviewCo-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>* Formating* Base estimator class* Apply suggestions from code reviewCo-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>* Formating* ConditionalDensityEstimator renaming* Apply suggestions from code reviewCo-authored-by: Jan <janfb@users.noreply.github.com>* suggestions* Fixing missing loss in SNPE_A---------Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>Co-authored-by: Jan <janfb@users.noreply.github.com>