Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

bugfix for tutorial on embedding net#1159

Merged
michaeldeistler merged 1 commit intomainfromtutorial_fix
May 28, 2024
Merged

Conversation

michaeldeistler
Copy link
Contributor

@codecovCodecov
Copy link

codecovbot commentedMay 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.81%. Comparing base(9a8c7c0) to head(7c2d21d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@##             main    #1159       +/-   ##===========================================- Coverage   83.93%   73.81%   -10.13%===========================================  Files          90       92        +2       Lines        6930     7259      +329     ===========================================- Hits         5817     5358      -459- Misses       1113     1901      +788
FlagCoverage Δ
unittests73.81% <ø> (-10.13%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 32 files with indirect coverage changes

Copy link
Collaborator

@psteinbpsteinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me! Thanks for contributing this small albeit important fix. :-)

@michaeldeistlermichaeldeistler merged commit1b268b8 intomainMay 28, 2024
5 checks passed
@michaeldeistlermichaeldeistler deleted the tutorial_fix branchMay 28, 2024 06:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@psteinbpsteinbpsteinb approved these changes

@manuelgloecklermanuelgloecklerAwaiting requested review from manuelgloeckler

@gmoss13gmoss13Awaiting requested review from gmoss13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@michaeldeistler@psteinb
[8]ページ先頭
©2009-2025 Movatter.jp