Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add(CI): eslint, prettier, typescript for npm related install scripts#14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kodiakhq merged 3 commits intomasterfromsteve/add-ci-for-js-install-scripts
Jun 17, 2020

Conversation

sbdchd
Copy link
Owner

Ensure we run typescript, eslint, and prettier against the js install
scripts used in the npm install method.

Ensure we run typescript, eslint, and prettier against the js installscripts used in the npm install method.
@sbdchdsbdchd added the automergeautomerge with kodiak labelJun 17, 2020
@kodiakhqkodiakhqbot merged commit19674ba intomasterJun 17, 2020
@kodiakhqkodiakhqbot deleted the steve/add-ci-for-js-install-scripts branchJune 17, 2020 03:24
@sbdchd
Copy link
OwnerAuthor

Test comment

@sbdchd
Copy link
OwnerAuthor

Another test comment

@squawk-squawk
Copy link

squawk-squawkbot commentedJun 20, 2020
edited by sbdchd
Loading

Squawk Report

2 violations across1 file(s)

./0077_ingredient_foo.sql

BEGIN;---- Add field foo to ingredient--ALTERTABLE"core_ingredient" ADD COLUMN"foo"text DEFAULT''NOT NULL;ALTERTABLE"core_ingredient" ALTER COLUMN"foo" DROP DEFAULT;COMMIT;

🚒 Rule Violations (2)

./0077_ingredient_foo.sql:2:1: warning: adding-not-nullable-field   2 | --   3 | -- Add field foo to ingredient   4 | --   5 | ALTER TABLE "core_ingredient" ADD COLUMN "foo" text DEFAULT '' NOT NULL;  note: Adding a NOT NULL field requires exclusive locks and table rewrites.  help: Make the field nullable../0077_ingredient_foo.sql:2:1: warning: adding-field-with-default   2 | --   3 | -- Add field foo to ingredient   4 | --   5 | ALTER TABLE "core_ingredient" ADD COLUMN "foo" text DEFAULT '' NOT NULL;  note: In Postgres versions <11 adding a field with a DEFAULT requires a table rewrite with an ACCESS EXCLUSIVE lock.  help: Add the field as nullable, then set a default, backfill, and remove nullabilty.

📚 More info on rules

⚡️ Powered bySquawk

kodiakhqbot pushed a commit that referenced this pull requestJun 21, 2020
Comment on Pull Requests with a comment containing SQL and the errors `squawk` reports.Could be paired with django migrations where a script runs [`sqlmigrate`](https://docs.djangoproject.com/en/3.0/ref/django-admin/#django-admin-sqlmigrate) to create `.sql` files for each migration.Then `squawk` runs over all those files and leaves a comment on the specified PR.Subsequent runs of `squawk` will update the existing comment. example:#14 (comment)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automergeautomerge with kodiak
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@sbdchd

[8]ページ先頭

©2009-2025 Movatter.jp