- Notifications
You must be signed in to change notification settings - Fork46
add(CI): eslint, prettier, typescript for npm related install scripts#14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Ensure we run typescript, eslint, and prettier against the js installscripts used in the npm install method.
Test comment |
Another test comment |
squawk-squawkbot commentedJun 20, 2020 • edited by sbdchd
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by sbdchd
Uh oh!
There was an error while loading.Please reload this page.
Squawk Report2 violations across1 file(s)
|
kodiakhqbot pushed a commit that referenced this pull requestJun 21, 2020
Comment on Pull Requests with a comment containing SQL and the errors `squawk` reports.Could be paired with django migrations where a script runs [`sqlmigrate`](https://docs.djangoproject.com/en/3.0/ref/django-admin/#django-admin-sqlmigrate) to create `.sql` files for each migration.Then `squawk` runs over all those files and leaves a comment on the specified PR.Subsequent runs of `squawk` will update the existing comment. example:#14 (comment)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure we run typescript, eslint, and prettier against the js install
scripts used in the npm install method.