- Notifications
You must be signed in to change notification settings - Fork11
ConstructorExpressions instead of Macros, No Describe Statement#7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
See some comments below.
Is there a need to make it above 740 ? I'm not using it in older systems but someone can potentially ... so I'm a bit tentative ...
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@sbcgua will you be dropping 702 compatibility? |
sbcgua commentedMar 8, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@larshp I'm pronenot to. But I'm not using this lib currently in my projects in our old system. So ... it depends on who uses it and where. How to find it out ? Maybe we can move 740 support into a branch ? @DerGuteWolf Could you pls tell what is your reasoning behind this PR ? |
larshp commentedMar 8, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
it might be a good example for automatically downporting using abaplint if needed |
@larshp |
describe is not allowed in steampunk, therefore the reason to remove this. Also Macros are not allowed in steampunk, therefore I substituted macros with VALUE construction expressions |
Thanks !
Would you mind if I ask you to measure the perf before and after and publish here ? If I remember well the test prog is already created - perf_test.prog - though it might need this -https://github.com/sbcgua/benchmarks - I don't remember for sure |
Will do this, however I need some shuffling around first. |
sbcgua commentedMar 12, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
OK.
@DerGuteWolf Thanks for the PR ! |


Fixes Issue#6
Provides Compatibility with Steampunk
Remove Compativility with < 740