Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Add time datatype#3

Open
pierredittgen wants to merge4 commits intosamuelmeuli:master
base:master
Choose a base branch
Loading
frompierredittgen:add_time_datatype

Conversation

@pierredittgen
Copy link

Hi, we begin a project involving use of wikibase and found your module very useful.

We need to deal with data value of type "time", so here is a proposition to implement it.

It seems to work for my needs but I was not able to run the tests. I do not understand what could be the content of config-tests.xml

Could you help me?

@samuelmeuli
Copy link
Owner

samuelmeuli commentedJan 24, 2020
edited
Loading

Thanks a lot for the PR!

I'll have to set up Wikibase and get the tests to work on my machine again, so it might take me a while to review this :)

@samuelmeulisamuelmeuli added the enhancementNew feature or request labelJan 24, 2020
@samuelmeuli
Copy link
Owner

samuelmeuli commentedFeb 9, 2020
edited
Loading

Alright, I've set up the testing environment again. Your code unfortunately isn't working yet.

I've now simplified the local setup guide a lot, this should get it to work on your device, too:https://wikibase-api.readthedocs.io/en/latest/development/development.html. Please let me know if I can provide more details :)

In case you get errors about duplicate items when running the tests, this might be because of a previously failed test run which didn't clean up its data properly. Creating a new Docker volume should do the trick.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@cbenzcbenzcbenz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierredittgen@samuelmeuli@cbenz

[8]ページ先頭

©2009-2025 Movatter.jp