- Notifications
You must be signed in to change notification settings - Fork5
Add time datatype#3
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
samuelmeuli commentedJan 24, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks a lot for the PR! I'll have to set up Wikibase and get the tests to work on my machine again, so it might take me a while to review this :) |
samuelmeuli commentedFeb 9, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Alright, I've set up the testing environment again. Your code unfortunately isn't working yet. I've now simplified the local setup guide a lot, this should get it to work on your device, too:https://wikibase-api.readthedocs.io/en/latest/development/development.html. Please let me know if I can provide more details :) In case you get errors about duplicate items when running the tests, this might be because of a previously failed test run which didn't clean up its data properly. Creating a new Docker volume should do the trick. |
Hi, we begin a project involving use of wikibase and found your module very useful.
We need to deal with data value of type "time", so here is a proposition to implement it.
It seems to work for my needs but I was not able to run the tests. I do not understand what could be the content of config-tests.xml
Could you help me?