Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

SEP 36: salt-ssh configurable compression proposal#58

Open
nergdron wants to merge2 commits intosaltstack:master
base:master
Choose a base branch
Loading
fromnergdron:master

Conversation

@nergdron
Copy link

This was recommended by@waynew on salt ticket60479. It's a feature request to be able to configure the compression type and level used on thin tarballs for distribution bysalt-ssh.

@welcome
Copy link

welcomebot commentedAug 30, 2021

Hello! Thank you for submitting a Salt Enhancement Proposal! Our process is detailed in theREADME.md and more about theSEP Life-cycle. An Open Core Team member will be assigned to follow up and help guide this SEP soon and you will find the this in the Community Slack channel #sep.
Please be sure to review ourCode of Conduct.
You can also check out some of our community
resources:
-Community Wiki
-Salt’s Contributor Guide
-Join our Community Slack
-IRC on LiberaChat
-SaltStack YouTube channel
-SaltStackInc Twitch channel

@nergdronnergdron requested a review froma team as acode ownerAugust 30, 2021 21:19
@nergdronnergdron requested review fromdhiltonp and removed request fora teamAugust 30, 2021 21:19
@waynewwaynew changed the titlesalt-ssh configurable compression proposalSEP 36: salt-ssh configurable compression proposalSep 13, 2021
@waynew
Copy link
Contributor

This will be SEP 36 - feel free to update your filename/file contents 👍

@waynew
Copy link
Contributor

👍 from me. I think it's a great idea, and it seems like something that would be straightforward to implement. The main risk that I see is around the config, as you called out in the SEP. We definitely have native minions that would have different compression tools available, but if we could use some kind of targeting similar to the way we do with top files, in theory that should solve the problem.

Itmay be possible that we have to ship that information alongside the thin, but I'm not positive, having not looked closely at that code lately 🙃.

I think it would be 100% possible to build up this functionality in layers - if we start with just allowing support for any of the built-in compression, we could merge that in and then work up to whatever alternative approaches we need.

@waynew
Copy link
Contributor

Apologies for the long hiatus, we're working to refocus on getting SEPs through the process.


To summarize:

No objections have been made, a few possible approaches were mentioned. Given the gap, after next week we'll go ahead and put this into final comment period.

@waynewwaynew added DraftInitial Status Final Comment PeriodSpeak now or forever hold your peace. and removed DraftInitial Status labelsFeb 15, 2022
@dmurphy18dmurphy18 self-requested a reviewFebruary 15, 2022 20:16
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@dhiltonpdhiltonpAwaiting requested review from dhiltonp

3 more reviewers

@waynewwaynewwaynew approved these changes

@whytewolfwhytewolfwhytewolf approved these changes

@dmurphy18dmurphy18dmurphy18 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Final Comment PeriodSpeak now or forever hold your peace.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nergdron@waynew@whytewolf@dmurphy18

[8]ページ先頭

©2009-2025 Movatter.jp