This repository was archived by the owner on Jan 24, 2024. It is now read-only.

saltstack/salt-enhancement-proposalsPublic archive

NotificationsYou must be signed in to change notification settings
Fork40
Star35

SEP 35: sep for standardizing log rotate settings in minion configs#57

Open

Bacon-Unlimited wants to merge2 commits intosaltstack:master

base:master

Choose a base branch

fromBacon-Unlimited:log-rotate-minion-configs

Open

SEP 35: sep for standardizing log rotate settings in minion configs#57

Bacon-Unlimited wants to merge2 commits intosaltstack:masterfromBacon-Unlimited:log-rotate-minion-configs

Conversation

Copy link

Bacon-Unlimited commentedAug 12, 2021

No description provided.

sep for standardizing log rotate settings in minion configs

d9be9d2

Bacon-Unlimited requested a review froma team as acode owner

August 12, 2021 18:10

Copy link

welcomebot commentedAug 12, 2021

Hello! Thank you for submitting a Salt Enhancement Proposal! Our process is detailed in theREADME.md and more about theSEP Life-cycle. An Open Core Team member will be assigned to follow up and help guide this SEP soon and you will find the this in the Community Slack channel #sep.
Please be sure to review ourCode of Conduct.
You can also check out some of our community
resources:
-Community Wiki
-Salt’s Contributor Guide
-Join our Community Slack
-IRC on LiberaChat
-SaltStack YouTube channel
-SaltStackInc Twitch channel

Bacon-Unlimited requested review fromdwoz and removed request fora team

August 12, 2021 18:10

Copy link

OrangeDog commentedAug 17, 2021

I assumed this was only implemented on Windows because it doesn't have the standardisedlogrotate system that the other supported platforms have.

Copy link

Author

Bacon-Unlimited commentedAug 17, 2021 via email

Hi James,Yeah, I was thinking the same thing. Unfortunately, it breaks cross-platform approaches to have those configs implemented only in Windows. Those configs, also represent the fastest method for a salt admin to protect against creeping log growth. They’re easy to use and understand, and take a salty approach to systems administration. To me, those configs make salt a better product because it makes things easier. So I still support having those be applied to all operating systems.

…

-------------------------------You get a Bacon! And you get a Bacon! Everyone gets a Bacon!Andrew BrittonVP of Development888-715-0003 x 10***@***.******@***.***>Made by IT people for IT people®***@***.***<http://www.baconunlimited.com/>From: James Howe ***@***.***>Sent: Tuesday, August 17, 2021 1:25 AMTo: saltstack/salt-enhancement-proposals ***@***.***>Cc: Andrew ***@***.***>; Author ***@***.***>Subject: Re: [saltstack/salt-enhancement-proposals] sep for standardizing log rotate settings in minion configs (#57)I assumed this was only implemented on Windows because it doesn't have the standardised logrotate system that the other supported platforms have.—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_saltstack_salt-2Denhancement-2Dproposals_pull_57-23issuecomment-2D900097419&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=SG3QRQJlZ1YtoxAghBFQ7U8TWK0qBLvaOelJTzfHxbc&m=pcj93DAa5jgE54_h2os_uYfLaK-a3U3VVsOvPtbfUaE&s=Z7rv4A9nauvRZwsVLGO6IieDAGUbAtwte8dMIPfeZsw&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AQSWHCBZUWDNJYXMXPW2QSTT5IMEHANCNFSM5CB2L4UQ&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=SG3QRQJlZ1YtoxAghBFQ7U8TWK0qBLvaOelJTzfHxbc&m=pcj93DAa5jgE54_h2os_uYfLaK-a3U3VVsOvPtbfUaE&s=z_zTQAWQjuqxcvACVkpF88CXRDmposQUbZi8k7BVrGQ&e=>.Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=SG3QRQJlZ1YtoxAghBFQ7U8TWK0qBLvaOelJTzfHxbc&m=pcj93DAa5jgE54_h2os_uYfLaK-a3U3VVsOvPtbfUaE&s=1YK-_T7LFPnBfMkSEOhtS9KyEaqjZ23Dcf8ITE7kxQ0&e=> or Android<https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26utm-5Fcampaign-3Dnotification-2Demail&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=SG3QRQJlZ1YtoxAghBFQ7U8TWK0qBLvaOelJTzfHxbc&m=pcj93DAa5jgE54_h2os_uYfLaK-a3U3VVsOvPtbfUaE&s=EI5iLQW7mEyKjG-uuvhsbxKsdordu7RW2DtKmTlRaNA&e=>.

sagetherage added the DraftInitial Status label

Aug 19, 2021

waynew changed the title~~sep for standardizing log rotate settings in minion configs~~SEP 35: sep for standardizing log rotate settings in minion configs

Aug 20, 2021

Copy link

Author

Bacon-Unlimited commentedSep 16, 2021•
edited
Loading

When adding the two config items to an Ubuntu salt-minion it created this error every second

(typed by hand... please forgive or inquire about mispellings

[salt.minion    :2879][CRITICAL][1013136] The beacon errored:Traceback (most recent call last):    File "/usr/lib/python3/dist-packages/salt/minion.py", line 2877, in handle_beacons        beacons = self.process_beacons(self.functions)    File "/usr/lib/python3/dist-packages/salt/minion.py", line 515, in process_beacons        return self.beacons.process(    File "/usr/lib/python3/dist-packages/salt/beacons/__init__.py", line 75, in process        b_config[mod].append({"_beacon_name": mod})AttributeError: 'dict' object has no attribute 'append'

Removal of the two log rotate minion config settings, and restarting the salt-minion service, stopped the error from being reported to the salt minion log file.

waynew previously requested changes

Oct 21, 2021

View reviewed changes

log-rotate-minion-configs.md OutdatedShow resolvedHide resolved

Copy link

Contributor

waynew commentedJan 5, 2022

Apologies for the long hiatus, we're working to refocus on getting SEPs through the process.

To summarize the current state:

There are a few requested changes that need to be made, there was some question/discussion around if this was due to the lack of logrotate on Windows (yes), and that if Salt handles/enables the settings that would keep the cross-platform consistency.

No objections have been raised. Requested changes should be made before this moves into final comment period.