This repository was archived by the owner on Jan 24, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork40
SEP 29: Proposed changes to the pkg beacon.#39
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Akm0d approved these changesDec 18, 2020
3 tasks
garethgreenaway added a commit to garethgreenaway/salt that referenced this pull requestFeb 9, 2021
… packages, but also when watched packages are installed or removed. Breaking out the logic for listing pkgs from context into a separate function to aid in testing. Updating tests to ensure context is not used when use_context option to list_pkgs is False.saltstack/salt-enhancement-proposals#39
3 tasks
Ch3LL pushed a commit to saltstack/salt that referenced this pull requestFeb 16, 2021
* Updating the pkg beacon to fire the events when there are upgrades to packages, but also when watched packages are installed or removed. Breaking out the logic for listing pkgs from context into a separate function to aid in testing. Updating tests to ensure context is not used when use_context option to list_pkgs is False.saltstack/salt-enhancement-proposals#39* Adding changelog file* Converting tests to pytest.* removing self from tests.pytests.unit.modules.test_yumpkg.test_pkg_hold_tdnf* swapping global variables for pytest fixtures.* Running pre-commit manually against salt/modules/pkgng.py salt/modules/freebsdpkg.py
waynew suggested changesJan 5, 2022
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Contributor
waynew commentedFeb 15, 2022
This SEP was approved and implemented |
Congratulations on your first PR being merged! 🎉 |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a SEP for change proposed changes to the pkg beacon.