- Notifications
You must be signed in to change notification settings - Fork5.6k
Fix pip.installed state managed pre-release upgrades#68526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:3006.x
Are you sure you want to change the base?
Fix pip.installed state managed pre-release upgrades#68526
Conversation
16ddd3a to2a05161Comparekurtrwall commentedDec 11, 2025
I've been able to trace the bug back to the inception of the code that usespip index versions, so I based the PR on the v3004.x branch, but I'm unsure if that was the appropriate one. I'm also having a bit of trouble with the tests, but I didn't want it to block the contribution. |
twangboy commentedDec 11, 2025
We do bug fixes on the olders supported branch where the bug exists. There will be no more releases of 3004 and 3005. The oldest supported branch is 3006.x. Please rebase this PR on 3006.x. |
`pip index versions` will never yield pre-release versions of thepackage without the `--pre` option.In effect, this means providing `pre_releases=True` and `upgrade=True`to the `pip.installed` state will never work, but I'm unsure of theactual extent of this bug.
2a05161 to7a239d1Comparekurtrwall commentedDec 11, 2025
Rebased to 3006.x and refactored the test a bit to utililze the new fixtures and provide more coverage. |
6213954 to2af6443Comparekurtrwall commentedDec 15, 2025
Hey all, thanks for the quick review of this PR. Out of curiousity, how does the release flow work? Does the bugfix get released to all major versions, i.e. 3006.+1, 3007.+1? |
twangboy commentedDec 16, 2025
It will be merged in to 3006.x and then we will merge-forward all those changes into future branches. |
Uh oh!
There was an error while loading.Please reload this page.
What does this PR do?
What issues does this PR fix or reference?
Fixes#68525
Previous Behavior
Python packages installed in an environment would not upgrade to their pre-release version when any exist in the index.
New Behavior
Pre-release versions of packages managed by
pip.installedstate are upgraded when usingupgrade=Trueandpre_releases=True.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No