- Notifications
You must be signed in to change notification settings - Fork5.6k
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default Checking mergeability… Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:saltstack/salt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:saltstack/salt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:opts_memory_optimization
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
Uh oh!
There was an error while loading.Please reload this page.
- 6commits
- 5files changed
- 1contributor
Commits on Dec 12, 2025
Add copy on write opts handling
Reduce duplicated data and memory consuption by adding copy on writeopts dictionary
Commits on Dec 14, 2025
Commits on Dec 16, 2025
Fix OptsDict shared value visibility for sibling children
Problem:When pyobjects renderer set grains/pillar on an OptsDict child, siblingchildren (other loaders) couldn't see those values. Siblings only seeparent _local dicts, not each other's _local dicts.Root Cause:In OptsDict, when child A sets opts["grains"], it goes into A's _local.When sibling child B tries to access opts["grains"], it walks up theparent chain checking _local dicts, but never finds A's _local becausethey're siblings.Fix:1. Added OptsDict.get_root() to find the root instance2. Added OptsDict.set_shared(key, value) to set values on root so all children can see them3. Modified pyobjects renderer to use set_shared() for grains/pillarThis ensures shared configuration values are visible to all loaders.Fixes:- Unit test failures: test_pyobjects.py (NameError: name 'Pkg' not defined)- Functional test failures: state file discovery and execution- All related to config visibility between loaders
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff master...opts_memory_optimization
Uh oh!
There was an error while loading.Please reload this page.