- Notifications
You must be signed in to change notification settings - Fork422
feat: add support for ElementInternals in synthetic shadow#5519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
roxanne-baker wants to merge9 commits intosalesforce:masterChoose a base branch fromroxanne-baker:synthetic-element-internals
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes from1 commit
Commits
Show all changes
9 commits Select commitHold shift + click to select a range
31414f3
feat: add support for ElementInternals in synthetic shadow
roxanne-baker0b3148a
Update packages/@lwc/engine-core/src/framework/base-lightning-element.ts
roxanne-bakerb6d2452
chore: update in response to review comments
roxanne-baker71eb0c5
test: add test for setting readonly props in ElementInternals
roxanne-baker32b2606
Update packages/@lwc/integration-not-karma/test/component/LightningEl…
roxanne-baker318abed
Update packages/@lwc/integration-not-karma/test/component/LightningEl…
roxanne-bakerc337695
Merge branch 'master' into synthetic-element-internals
roxanne-baker1a8b40b
fix: fix test
roxanne-bakeraafc70f
feat: add enableSyntheticElementInternals flag
roxanne-bakerFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Update packages/@lwc/integration-not-karma/test/component/LightningEl…
…ement.attachInternals/elementInternals/formAssociated/index.spec.jsCo-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit32b2606db809297c1cd200d4a4081a4dbcc3c3b9
There are no files selected for viewing
19 changes: 0 additions & 19 deletions.../component/LightningElement.attachInternals/elementInternals/formAssociated/index.spec.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -127,25 +127,6 @@ describe.runIf(ENABLE_ELEMENT_INTERNALS_AND_FACE && typeof ElementInternals !== | ||
expect(internals.labels[0]).toBe(label); | ||
}); | ||
for (const prop of readOnlyProperties) { | ||
it(`should throw error when trying to set ${prop} on form associated component`, () => { | ||
roxanne-baker marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
const elm = createElement('x-form-associated', { is: FormAssociated }); | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.