- Notifications
You must be signed in to change notification settings - Fork434
Add new prop to configure tree node selectable#3083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Add new prop to configure tree node selectable#3083
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for opening this pull request! 💯 This is a community-driven project, and we can't do it without your participation. Please check out ourcontributing guidelines and review the Contributor Checklist if you haven't already, to make sure everything is squared away. CircleCI will take about 10 minutes to run through the same items that are on the Contributor checklist with a pass/fail check below. Please fix any issues that cause CircleCI to fail or ask for clarification--we try, but sometimes the errors can be unclear. |
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Yaoyao Lin <y***@s***.com>. One possible solution is toadd that email to your GitHub account. Alternatively you canchange your commits to another email and force push the change. After getting your commits associated with your GitHub account,refresh the status of this Pull Request. |
@lyy011lyy Hi, I've been on work leave until this week. Elements with role I haven't looked over the PR yet, but am discussing what the Definition of Done for handling keyboard only use would look like in a Tree pattern that confirms to the ARIA spec, and I'm having difficulty with it. This library implements the patterns here:https://www.lightningdesignsystem.com/components/trees/ which are the scope of this component. Based on the screenshot, you may be helped by the Tree Grid pattern which does allow multiple focusable elements. A full TreeGrid pattern has not been added to this library. It would be great to add it. Here is a branch that is close to what you are looking for with a TreeGrid pattern + dropdown menu column.#2181 The interactions and accessibility were never completed though however in order to add it officially to this library. |
Fixes #
In some cases, we don't want the tree node to be selectable and keep refreshing itself, the issue description:#3081
So I'm thinking to introduce this new prop for the Tree component to make the selectable node configurable.
Additional description
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fix
has been run and linting passes.components/component-docs.json
CI tests pass (npm test
).REVIEWER checklist (do not remove)
components/component-docs.json
tests.Required only if there are markup / UX changes
last-slds-markup-review
inpackage.json
and push.last-accessibility-review
, topackage.json
and push.npm run local-update
within locally clonedsite repo to confirm the site will function correctly at the next release.