- Notifications
You must be signed in to change notification settings - Fork306
refactor(snippet): rework luasnip source#2238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
soifou wants to merge11 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8539836 to2ed5d8eCompareblink.cmp v1.0.0 has been release 8 months ago, this check can besafely removed now.
Instead of displaying only `trigger`, first try to generate thepreview from the snippet's textNodes; if that's not available, fallback to `docTrig` if it exists, or use the `trigger` as a last resort.
This setting, which prefers `docTrig` over the trigger, is confusing andhas seen little adoption despite its usefulness.Users can still opt out in v1.0, but the option will be removed in v2.0to simplify the codebase.
Update lua annotations using refactor branchFix `docTrig` replacement using Luasnip v2.4.1Add initial support for choice nodes
2ed5d8e toa280624CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Some refactoring on this source for easier maintenance with better annotations.
A potential fix for#1081. Possibly a race condition causing duplicated snippets due to premature cache initialization. I haven't been able to reproduce it myself, so if anyone wants to test it out, that'd be great!
The
insertTextis "improved" to be more like other snippet engines or LSPs. For example, for awhile~snippet, it showswhi|le true doinstead of the actualwhi|le, with support of multi-line snippets, etc., (fallback to the label/trigger). I think it'd align better with what we observe elsewhere.Deprecation of
opts.prefer_doc_trig(defaulttrue, to be removed inv2) since it has proven very useful and reliable over the months since its introduction.TODO: