- Notifications
You must be signed in to change notification settings - Fork306
fix(winborder): handle custom border chars#1984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hey, thanks for the PR! I had a few suggestions:
Unrelated to your change, but while we're at it: for checking if the option exists, I think using |
I don't think this is necessary since it should validate this when setting the option
Good point, I can try it out
I didn't know it worked for options🤔 will try this as well |
74f3980 tob1123dbCompareb1123db tofca9294CompareI changed to using Before custom borderchars, it returned a string, but now it returns a table. It should work for both scenarios. Before custom border chars: None of the supported string values have a length of 1, and we will fallback to After custom border chars: It will always return a table, and for the string values, we need to unpack it, and for the custom border chars, we just return the table |
a946054 intosaghen:mainUh oh!
There was an error while loading.Please reload this page.
Thank you both! |
Uh oh!
There was an error while loading.Please reload this page.
Neovim just got support for custom border chars in the winborder option.
Assume the border characters are custom if winborder option contains
,neovim/neovim#33772