Commit742463e

authored and

committed

Increase ob's ref count in tp_repr to avoid accidental free

1 parent9fb545a commit742463eCopy full SHA for 742463e

File tree

-0

lines changed

-0

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -73,4 +73,5 @@`
`73`	`73`	`- ([@rmadsen-ks](https://github.com/rmadsen-ks))`
`74`	`74`	`- ([@stonebig](https://github.com/stonebig))`
`75`	`75`	`- ([@testrunner123](https://github.com/testrunner123))`
	`76`	`+- ([@DanBarzilian](https://github.com/DanBarzilian))`
`76`	`77`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,8 @@ This document follows the conventions laid out in [Keep a CHANGELOG][].`
`13`	`13`
`14`	`14`	`###Fixed`
`15`	`15`
	`16`	`+- Fix incorrect dereference of wrapper object in tp_repr, which may result in a program crash`
	`17`	`+`
`16`	`18`	`##[2.5.0][] - 2020-06-14`
`17`	`19`
`18`	`20`	`This version improves performance on benchmarks significantly compared to 2.3.`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -266,6 +266,7 @@ public static IntPtr tp_repr(IntPtr ob)`
`266`	`266`
`267`	`267`	`//otherwise use the standard object.__repr__(inst)`
`268`	`268`	`IntPtrargs=Runtime.PyTuple_New(1);`
	`269`	`+Runtime.XIncref(ob);`
`269`	`270`	`Runtime.PyTuple_SetItem(args,0,ob);`
`270`	`271`	`IntPtrreprFunc=Runtime.PyObject_GetAttrString(Runtime.PyBaseObjectType,"__repr__");`
`271`	`272`	`varoutput=Runtime.PyObject_Call(reprFunc,args,IntPtr.Zero);`

Comments

(0)