NotificationsYou must be signed in to change notification settings
Fork15.2k
Star103k

Fix GUI closing when enabling service on Windows (#7010)#11915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

GlassOnTin wants to merge2 commits intorustdesk:master

base:master

Choose a base branch

fromGlassOnTin:fix-gui-close-service-install-complete

Open

Fix GUI closing when enabling service on Windows (#7010)#11915

GlassOnTin wants to merge2 commits intorustdesk:masterfromGlassOnTin:fix-gui-close-service-install-complete

Conversation

Copy link

GlassOnTin commentedMay 29, 2025

Summary

This PR fixes the issue where the RustDesk GUI closes immediately (~500ms) when attempting to enable the service on Windows.

Problem

When enabling the service, the GUI would close immediately due to:

GUI process has IPC server on\\.\pipe\RustDesk\query
Service process tries to create IPC server on the same pipe
Service gets "Access is denied" error
Service callsstop_main_window_process() which sendsClose message to GUI
GUI exits without restarting (unlike Linux/macOS)

Solution

This PR implements a three-part fix:

1. Server-side improvements (server.rs)

Added retry logic with exponential backoff (up to 10 attempts)
Added environment variable checkRUSTDESK_SERVICE_INSTALLATION to detect service installation
Prevents killing GUI process during service installation scenario

2. Client-side improvements (ipc.rs)

Added Windows support to restart GUI after receivingClose message
GUI restarts with--no-server flag after 2-second delay
Matches the behavior on Linux/macOS where GUI restarts during service installation

3. Increased timeouts

More generous retry attempts and wait times to allow proper IPC handover

Testing

To test this fix:

Build RustDesk with these changes
Start RustDesk GUI on Windows
Go to Settings and enable the service
The GUI should briefly close and restart instead of closing permanently

Related Issue

Fixes#7010

Alternative Approaches Considered

Having GUI close its IPC server before starting service (more complex)
Using different pipe names for GUI vs service (would break compatibility)
This approach is minimally invasive and maintains backward compatibility

GlassOnTin added2 commits

May 29, 2025 15:04

Fix GUI closing immediately when enabling service

1d24fcb

- Add retry logic with up to 10 attempts for IPC connection- Detect service installation/startup state to prevent premature closure- Implement exponential backoff for connection retries- Check installing_service() flag for accurate service state detectionThis fixes the issue where the GUI would close within ~500ms whenenabling the service due to 'Access is denied' IPC errors.Fixesrustdesk#7010

Fix GUI closing when enabling service on Windows

64cfdf6

This fixes issuerustdesk#7010 where the RustDesk GUI closes immediately when enabling the service.The problem was:1. GUI has IPC server on \\.\\pipe\\RustDesk\\query2. Service tries to start and create IPC server on same pipe3. Service gets 'Access is denied' error4. Service calls stop_main_window_process() which sends Close message to GUI5. GUI exits immediatelyThe fix:1. Added retry logic with exponential backoff (up to 10 attempts) in server.rs2. Added environment variable check to avoid killing GUI during service installation3. Added Windows support in ipc.rs to restart GUI after receiving Close message4. Increased wait times to allow proper handover of IPC server from GUI to serviceThis allows the GUI to gracefully restart while the service takes over the IPC server.

GlassOnTin force-pushed thefix-gui-close-service-install-complete branch from8471167 to64cfdf6Compare

May 29, 2025 15:35