- Notifications
You must be signed in to change notification settings - Fork5
Support Range<NaiveDate> for daterange#18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
the-kenny wants to merge6 commits intorust-postgres:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This fixes one tests for non-UTC systems.
This makes no sense as there is no default 'timerange' type.
Uh oh!
There was an error while loading.Please reload this page.
> The built-in range types int4range, int8range,> and daterange all use a canonical form that> includes the lower bound and excludes the upper> bound; that is, [).https://www.postgresql.org/docs/current/rangetypes.html#RANGETYPES-DISCRETEThis is implemented by modifying the`bounded_normalize` macro to take a `$delta`expression (`1` for `i32` and `i64`,`Duration::days(1)` for `NaiveDate`).
@sfackler I finally got around to fixing |
lgrosz commentedMar 24, 2025
Will this get merged? |
lgrosz added a commit to lgrosz/climb-graphql that referenced this pull requestMar 24, 2025
This _does not_ add the date window support, yet. This is because thereis not a great native rust-postgres way of getting PostgreSQLs DATERANGEtype. Looks like there'srust-postgres/rust-postgres-range#18, but it hasn'tbeen merged in a year and the general state of rust-postgres-range seemsunmaintained.. perhaps@tkbrigham has a good point inrust-postgres/rust-postgres#601.. it'd be great if all the PostgreSQLfeatures were supported in rust-postgres directly.
lgrosz added a commit to lgrosz/climb-graphql that referenced this pull requestMar 24, 2025
This _does not_ add the date window support, yet. This is because thereis not a great native rust-postgres way of getting PostgreSQLs DATERANGEtype. Looks like there'srust-postgres/rust-postgres-range#18, but it hasn'tbeen merged in a year and the general state of rust-postgres-range seemsunmaintained.. perhaps@tkbrigham has a good point inrust-postgres/rust-postgres#601.. it'd be great if all the PostgreSQLfeatures were supported in rust-postgres directly.
lgrosz added a commit to lgrosz/climb-graphql that referenced this pull requestMar 25, 2025
This _does not_ add the date window support, yet. This is because thereis not a great native rust-postgres way of getting PostgreSQLs DATERANGEtype. Looks like there'srust-postgres/rust-postgres-range#18, but it hasn'tbeen merged in a year and the general state of rust-postgres-range seemsunmaintained.. perhaps@tkbrigham has a good point inrust-postgres/rust-postgres#601.. it'd be great if all the PostgreSQLfeatures were supported in rust-postgres directly.
lgrosz added a commit to lgrosz/climb-graphql that referenced this pull requestMar 28, 2025
This _does not_ add the date window support, yet. This is because thereis not a great native rust-postgres way of getting PostgreSQLs DATERANGEtype. Looks like there'srust-postgres/rust-postgres-range#18, but it hasn'tbeen merged in a year and the general state of rust-postgres-range seemsunmaintained.. perhaps@tkbrigham has a good point inrust-postgres/rust-postgres#601.. it'd be great if all the PostgreSQLfeatures were supported in rust-postgres directly.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
NormalizableforNaiveDateto supportRange<Date>. It also changesassert!toassert_eq!in a few places to improve the test output.Note that I had to
#[ignore]the new test I added because Postgres normalises(2023-01-01,)to[2023-01-02,), which makes the test fail astest_typesdoes a by-value comparison.