- Notifications
You must be signed in to change notification settings - Fork515
Docs: make sure it's hard to miss that type name has to match#955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
vargad wants to merge1 commit intorust-postgres:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Docs: make sure it's hard to miss that type name has to match#955
vargad wants to merge1 commit intorust-postgres:masterfromvargad:docs_make_name_match_requirement_more_apparent
+3 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
I think it would be better to actually use the attribute rather than to have it there but commented out. |
Some people (me) doesn't read the full page or just gloss over thenaming section. It's a lot of wasted time debugging the issue when thetype name is not matching, adding name attribute to the examplesmakes it really hard to miss.
9a6221c to79151c5CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Some people (me) doesn't read the full page or just gloss over the naming section. It's a lot of wasted time debugging the issue when the type name is not matching, adding name attribute to the examples makes it really hard to miss.
Closes#940