Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add hostaddr support#945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sfackler merged 17 commits intorust-postgres:masterfromtrungda:tdinh/hostaddr
Jul 17, 2023
Merged

Conversation

trungda
Copy link
Contributor

@trungdatrungda commentedAug 26, 2022
edited
Loading

More details in#943.
Essentially, if we could provide bothhost andhostaddr, we can avoid an extra DNS lookup to establish a connection to the DB. Specifically, if bothhost andhostaddr are provided,hostaddr is going to be used to create the socket, i.e., as a raw IP address.host is still needed for TLS validation.

Testing

cargo test returns 4 failing tests which are already failing in master

---- test::scram_user stdout ----thread 'test::scram_user' panicked at 'called `Result::unwrap()` on an `Err` value: Error { kind: Tls, cause: Some(Error { code: -67843, message: "The certificate was not trusted." }) }', postgres-native-tls/src/test.rs:18:71note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace---- test::require stdout ----thread 'test::require' panicked at 'called `Result::unwrap()` on an `Err` value: Error { kind: Tls, cause: Some(Error { code: -67843, message: "The certificate was not trusted." }) }', postgres-native-tls/src/test.rs:18:71---- test::runtime stdout ----thread 'test::runtime' panicked at 'called `Result::unwrap()` on an `Err` value: Error { kind: Tls, cause: Some(Error { code: -67843, message: "The certificate was not trusted." }) }', postgres-native-tls/src/test.rs:91:6---- test::prefer stdout ----thread 'test::prefer' panicked at 'called `Result::unwrap()` on an `Err` value: Error { kind: Tls, cause: Some(Error { code: -67843, message: "The certificate was not trusted." }) }', postgres-native-tls/src/test.rs:18:71failures:    test::prefer    test::require    test::runtime    test::scram_usertest result: FAILED. 0 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s

I would be happy to make them work again in future PRs.

Dzordzu, kushudai, and lyang24 reacted with heart emoji
@trungda
Copy link
ContributorAuthor

@sfackler could you help take a look at the latest commit? Thank you :)

@trungdatrungda requested a review fromsfacklerAugust 31, 2022 04:15
@trungda
Copy link
ContributorAuthor

@sfackler could you help take a look? Thank you :)

@trungda
Copy link
ContributorAuthor

@sfackler could you help take a look? Thanks :)

@trungda
Copy link
ContributorAuthor

@sfackler would be great if you could take a look :) We have to use a forked version of rust-postgres now and I am worried it might be diverged from upstream :)

@trungda
Copy link
ContributorAuthor

@sfackler could you help take a look? Thank you :) !

@trungda
Copy link
ContributorAuthor

trungda commentedDec 27, 2022
edited
Loading

@sfackler happy holidays :) Could you help take a look at this PR? I am happy to address any feedback you might have. Thank you!

@trungda
Copy link
ContributorAuthor

@sfackler could you help take a look at this PR :) Thank you!

@trungda
Copy link
ContributorAuthor

@sfackler could you help take a look :) We have been running this branch in production for a few months now so I am confident that this works.

@trungda
Copy link
ContributorAuthor

Hi@sfackler , could you help review this PR when you have time? Thank you :)

@trungda
Copy link
ContributorAuthor

Hi@sfackler , could you help take a look at this PR when you have time :) Thank you!

@sfackler
Copy link
Collaborator

Sorry for the very long delay! This looks good to me.

kushudai reacted with heart emoji

@sfacklersfackler merged commit4f41157 intorust-postgres:masterJul 17, 2023
@trungdatrungda deleted the tdinh/hostaddr branchAugust 13, 2023 04:21
@trungda
Copy link
ContributorAuthor

Sorry for the very long delay! This looks good to me.

Thank you@sfackler ! Happy to contribute more to the project!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sfacklersfacklerAwaiting requested review from sfackler

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trungda@sfackler

[8]ページ先頭

©2009-2025 Movatter.jp