- Notifications
You must be signed in to change notification settings - Fork516
Add hostaddr support#945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@sfackler could you help take a look at the latest commit? Thank you :) |
@sfackler could you help take a look? Thank you :) |
@sfackler could you help take a look? Thanks :) |
@sfackler would be great if you could take a look :) We have to use a forked version of rust-postgres now and I am worried it might be diverged from upstream :) |
@sfackler could you help take a look? Thank you :) ! |
trungda commentedDec 27, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@sfackler happy holidays :) Could you help take a look at this PR? I am happy to address any feedback you might have. Thank you! |
@sfackler could you help take a look at this PR :) Thank you! |
@sfackler could you help take a look :) We have been running this branch in production for a few months now so I am confident that this works. |
Hi@sfackler , could you help review this PR when you have time? Thank you :) |
Hi@sfackler , could you help take a look at this PR when you have time :) Thank you! |
Sorry for the very long delay! This looks good to me. |
Thank you@sfackler ! Happy to contribute more to the project! |
Uh oh!
There was an error while loading.Please reload this page.
More details in#943.
Essentially, if we could provide both
host
andhostaddr
, we can avoid an extra DNS lookup to establish a connection to the DB. Specifically, if bothhost
andhostaddr
are provided,hostaddr
is going to be used to create the socket, i.e., as a raw IP address.host
is still needed for TLS validation.Testing
cargo test
returns 4 failing tests which are already failing in masterI would be happy to make them work again in future PRs.