- Notifications
You must be signed in to change notification settings - Fork515
Delegate encode_format to T in &T and Option<T>#928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
It's useful to be able to inspect Format values when debugging.
In the ToSql impls for &T and Option<T>, override encode_format todelegate to the impl for T. This ensures that if T overrides thismethod, it also overrides it for &T and Option<T>.
Thanks! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
#836 has been really useful for my use case, and this PR makes some small improvements to it.
I have a custom type (call it
T) thatimplsToSql, and I overrideencode_format. However in some situations I'm working with&TorOption<T>and I wantto_sqlto use the format that I've specified inencode_format. This change ensures that by delegating toT::encode_formatin these cases.As well as being useful, I believe this fixes a correctness issue, as these types already delegate to their inner type to implement
to_sql, so they should do the same forencode_formatto avoid emitting, e.g., a text encoding that is tagged as binary.I've also added
[derive(Clone, Copy, Debug)]toFormat, as it's a simple enum and this makes working with it a bit easier.