- Notifications
You must be signed in to change notification settings - Fork516
Boxed owned query parameters#853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- Box<dyn ToSql + Sync>- Box<dyn ToSql + Sync + Send>
Seems reasonable to me. Anything still need to added to this before switching it from a draft? |
elpiel commentedDec 16, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The onlynice to have is: Would there be an implication of the Boxed type when calling |
elpiel commentedDec 16, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Here's another thing: This will allow a use case in which I dynamically building the query values. Example use case:
|
elpiel commentedDec 31, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@sfackler could you merge this PR? PS: You can also check PR#859 which adds another impl that allows#853 (comment) |
Uh oh!
There was an error while loading.Please reload this page.
Related issue:#843
This allows usage of
Vec<Box<dyn ToSql + Sync>>
&Vec<Box<dyn ToSql + Sync + Send>>
to be used withClient.query_raw