- Notifications
You must be signed in to change notification settings - Fork516
Fix handling of raw ident fields in derive#841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| let ident = raw.ident.as_ref().unwrap().clone(); | ||
| Ok(Field{ | ||
| name: overrides.name.unwrap_or_else(|| ident.to_string()), | ||
| name: overrides.name.unwrap_or_else(||{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@dtolnay am I right in thinking that there's nothing that uses IdentFragment to create a string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not that I know of. IdentFragment isn't intended for anything other than using in format_ident.
Closes#839