- Notifications
You must be signed in to change notification settings - Fork516
Fix deadlock when pipelining statements.#773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
56 changes: 34 additions & 22 deletionstokio-postgres/src/client.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -54,17 +54,32 @@ impl Responses { | ||
} | ||
} | ||
/// A cache of type info and prepared statements for fetching type info | ||
/// (corresponding to the queries in the [prepare](prepare) module). | ||
#[derive(Default)] | ||
struct CachedTypeInfo { | ||
/// A statement for basic information for a type from its | ||
/// OID. Corresponds to [TYPEINFO_QUERY](prepare::TYPEINFO_QUERY) (or its | ||
/// fallback). | ||
typeinfo: Option<Statement>, | ||
/// A statement for getting information for a composite type from its OID. | ||
/// Corresponds to [TYPEINFO_QUERY](prepare::TYPEINFO_COMPOSITE_QUERY). | ||
typeinfo_composite: Option<Statement>, | ||
/// A statement for getting information for a composite type from its OID. | ||
/// Corresponds to [TYPEINFO_QUERY](prepare::TYPEINFO_COMPOSITE_QUERY) (or | ||
/// its fallback). | ||
typeinfo_enum: Option<Statement>, | ||
/// Cache of types already looked up. | ||
types: HashMap<Oid, Type>, | ||
} | ||
pub struct InnerClient { | ||
sender: mpsc::UnboundedSender<Request>, | ||
cached_typeinfo: Mutex<CachedTypeInfo>, | ||
/// A buffer to use when writing out postgres commands. | ||
buffer: Mutex<BytesMut>, | ||
erikjohnston marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
} | ||
impl InnerClient { | ||
@@ -82,48 +97,50 @@ impl InnerClient { | ||
} | ||
pub fn typeinfo(&self) -> Option<Statement> { | ||
self.cached_typeinfo.lock().typeinfo.clone() | ||
} | ||
pub fn set_typeinfo(&self, statement: &Statement) { | ||
self.cached_typeinfo.lock().typeinfo = Some(statement.clone()); | ||
} | ||
pub fn typeinfo_composite(&self) -> Option<Statement> { | ||
self.cached_typeinfo.lock().typeinfo_composite.clone() | ||
} | ||
pub fn set_typeinfo_composite(&self, statement: &Statement) { | ||
self.cached_typeinfo.lock().typeinfo_composite = Some(statement.clone()); | ||
} | ||
pub fn typeinfo_enum(&self) -> Option<Statement> { | ||
self.cached_typeinfo.lock().typeinfo_enum.clone() | ||
} | ||
pub fn set_typeinfo_enum(&self, statement: &Statement) { | ||
self.cached_typeinfo.lock().typeinfo_enum = Some(statement.clone()); | ||
} | ||
pub fn type_(&self, oid: Oid) -> Option<Type> { | ||
self.cached_typeinfo.lock().types.get(&oid).cloned() | ||
} | ||
pub fn set_type(&self, oid: Oid, type_: &Type) { | ||
self.cached_typeinfo.lock().types.insert(oid, type_.clone()); | ||
} | ||
pub fn clear_type_cache(&self) { | ||
self.cached_typeinfo.lock().types.clear(); | ||
} | ||
/// Call the given function with a buffer to be used when writing out | ||
/// postgres commands. | ||
pub fn with_buf<F, R>(&self, f: F) -> R | ||
where | ||
F: FnOnce(&mut BytesMut) -> R, | ||
{ | ||
let mutbuffer = self.buffer.lock(); | ||
let r = f(&mutbuffer); | ||
buffer.clear(); | ||
r | ||
} | ||
} | ||
@@ -160,13 +177,8 @@ impl Client { | ||
Client { | ||
inner: Arc::new(InnerClient { | ||
sender, | ||
cached_typeinfo: Default::default(), | ||
buffer: Default::default(), | ||
}), | ||
#[cfg(feature = "runtime")] | ||
socket_config: None, | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.