- Notifications
You must be signed in to change notification settings - Fork516
Fix deadlock when pipelining statements.#773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When executing statements in parallel there is a race where we preparethe type info queries multiple times, and so insert into the type infocaches multiple times. This resulted in any existing cached `Statement`to be dropped, running its destructor which attempts to take out thestate lock that is already being held, resulting in a deadlock.Fixesrust-postgres#772.
There is no reason for the buffer and typeinfo caches to share the samelock. By splitting them it means we a) get slightly better performance,but more importantly b) it makes it harder to accidentally deadlock.
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#772.
The first commit implements the suggestion from the issue to not overwrite any existing cached statements, which should be enough to fix the bug. The second commit splits the cached type info and the byte buffer to have separate locks, to try and reduce the risk of similar bugs happening again.
I've also tried to document a few things which I spent some time puzzling out, though they may only make sense to me so I'm happy to back them out.