- Notifications
You must be signed in to change notification settings - Fork516
Re-add savepoint method to Transaction#600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
sfackler merged 1 commit intorust-postgres:masterfromnvb:nvanbenschoten/savepoints-2-the-revival-albumMay 1, 2020
Merged
Re-add savepoint method to Transaction#600
sfackler merged 1 commit intorust-postgres:masterfromnvb:nvanbenschoten/savepoints-2-the-revival-albumMay 1, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Revivesrust-postgres#184.The rewrite for async/await and Tokio accidentally lost functionalitythat allowed users to assign specific names to savepoints when usingnested transactions. This functionality had originally been addedinrust-postgres#184 and had been updated inrust-postgres#374.This commit revives this functionality using a similar scheme to theone that existed before. This should allow CockroachDB users to updateto the next patch release of version `0.17`.
Thanks! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revives#184.
The rewrite for async/await and Tokio accidentally lost functionality
that allowed users to assign specific names to savepoints when using
nested transactions. This functionality had originally been added
in#184 and had been updated in#374.
This commit revives this functionality using a similar scheme to the
one that existed before. This should allow CockroachDB users to update
to the next patch release of version
0.17.