NotificationsYou must be signed in to change notification settings
Fork515
Star3.8k

fix an Error/Display impl#1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

paolobarbolini merged 1 commit intorust-postgres:masterfromCobaltCause:push-sswwslomtkmm

Oct 7, 2025

Merged

fix an Error/Display impl#1262

paolobarbolini merged 1 commit intorust-postgres:masterfromCobaltCause:push-sswwslomtkmm

Oct 7, 2025

+23 −45

Conversation

Copy link

Contributor

CobaltCause commentedAug 16, 2025

Types implementing the Error trait should print some inner Errorxor return that inner Error from its Error::source impl. Otherwise, the same error will be printed multiple times when printing an Error's entire source chain, which is unhelpful.

paolobarbolini approved these changes

Sep 20, 2025

View reviewed changes

Copy link

Member

paolobarbolini commentedSep 20, 2025•
edited
Loading

Could you rebase and fix tests?

This was linked to issuesSep 20, 2025

tokio_postgres::Error duplicates cause's description#976

Closed

Display impl ofError is not optimal#831

Open

This was unlinked from issuesSep 20, 2025

Display impl ofError is not optimal#831

Open

tokio_postgres::Error duplicates cause's description#976

Closed

paolobarbolini linked an issue

Sep 20, 2025

that may beclosed by this pull request

tokio_postgres::Error duplicates cause's description#976

Closed

CobaltCause force-pushed thepush-sswwslomtkmm branch froma52f18f to7db5bc6Compare

October 6, 2025 23:26

fix an Error/Display impl

c5d3442

Types implementing the Error trait should print some inner Error **xor**return that inner Error from its Error::source impl. Otherwise, the sameerror will be printed multiple times when printing an Error's entiresource chain, which is unhelpful.

CobaltCause force-pushed thepush-sswwslomtkmm branch from7db5bc6 toc5d3442Compare

October 6, 2025 23:31

Copy link

ContributorAuthor

CobaltCause commentedOct 6, 2025

Done.

Also FWIW, and I'm not 100% sure, but it seems like there might be another case of this kind of thing here:

rust-postgres/postgres-openssl/src/lib.rs

Lines 169 to 192 inbbd1301

	#[derive(Debug)]
	structConnectError{
	error: ssl::Error,
	verify_result:X509VerifyResult,
	}

	impl fmt::DisplayforConnectError{
	fnfmt(&self,fmt:&mut fmt::Formatter<'_>) -> fmt::Result{
	fmt::Display::fmt(&self.error, fmt)?;

	ifself.verify_result !=X509VerifyResult::OK{
	fmt.write_str(": ")?;
	fmt::Display::fmt(&self.verify_result, fmt)?;
	}

	Ok(())
	}
	}

	implErrorforConnectError{
	fnsource(&self) ->Option<&(dynError +'static)>{
	Some(&self.error)
	}
	}