- Notifications
You must be signed in to change notification settings - Fork514
expose sync rollback as a private api method#1230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fredr added a commit to encoredev/encore that referenced this pull requestApr 9, 2025
Adds support for transactions in runtimes/core and runtimes/jsWe should probably mergeencoredev/rust-postgres#1 and update Cargo.tomlagain. (suggested that change upstream as wellrust-postgres/rust-postgres#1230)
paolobarbolini requested changesSep 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sounds like a good idea.
Uh oh!
There was an error while loading.Please reload this page.
Thanks for reviewing! I've addressed your comment |
paolobarbolini approved these changesSep 22, 2025
fc27042 intorust-postgres:master 4 checks passed
Uh oh!
There was an error while loading.Please reload this page.
goodcode2000 added a commit to goodcode2000/encore that referenced this pull requestOct 2, 2025
Adds support for transactions in runtimes/core and runtimes/jsWe should probably mergeencoredev/rust-postgres#1 and update Cargo.tomlagain. (suggested that change upstream as wellrust-postgres/rust-postgres#1230)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't know if this is the correct approach, I just saw that sync close was exposed the same way.
It would be useful to have this exposed so that one can implement their own transaction type with a drop implementation that rolls back.
The reason I would like to implement my own transaction type is that I want to expose it to nodejs via napi-rs, and it is not possible to share things that have a lifetime over that boundary.