NotificationsYou must be signed in to change notification settings
Fork515
Star3.8k

fix fromsql for domains#1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

paolobarbolini merged 2 commits intorust-postgres:masterfromzacknewman:master

Sep 21, 2025

Merged

fix fromsql for domains#1189

paolobarbolini merged 2 commits intorust-postgres:masterfromzacknewman:master

Sep 21, 2025

Conversation

Copy link

Contributor

zacknewman commentedNov 20, 2024

Fixes#1188.

fix fromsql for domains

113d410

Copy link

Collaborator

sfackler commentedNov 22, 2024

Can you add a test for the case that was failing before this fix?

add test for composite in domain in composite

cc17f8e

Copy link

ContributorAuthor

zacknewman commentedNov 22, 2024

Added a test.

Copy link

ContributorAuthor

zacknewman commentedFeb 5, 2025•
edited
Loading

@sfackler, ping. Is it possible this gets merged? Currently one has to maintain their own fork that isn't affected by this bug, manually implementFromSql instead ofderiveing it, or live without the ability to construct certain types in PostgreSQL (which ideally would be documented at least). Can I improve the PR somehow?