Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Make error::Kind public#1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
levkk wants to merge3 commits intorust-postgres:master
base:master
Choose a base branch
Loading
fromlevkk:levkk-make-error-pub

Conversation

levkk
Copy link
Contributor

@levkklevkk commentedNov 1, 2024•
edited
Loading

Makeerror::Kind public and provide a getter. This allows lib/app code to handle different kind of errors, e.g.

match err.kind(){Kind::Column(name) =>panic!("You forgot to include column {} into the query", name),Kind::Parameter(_, _) =>panic!("You forgot to pass a parameter to the prepared statement"),    kind =>panic!("{:?}", kind),}

I documented errors I know about, but the ones I don't know what they do I left undocumented, hiding the doc warning.

demhadais, Aceeri, and vizh reacted with thumbs up emoji
@BaptisteRoseau
Copy link

Also made it here#1138 with a few test cases but it seems like it won't be merge any time soon..

@Aceeri
Copy link

This is something I also would love, I've just ended up doingerr.to_string() and re-parsing it which is pretty counterproductive.

Comment on lines 347 to 348
ToSql(usize),
FromSql(usize),
Copy link
Member

@paolobarbolinipaolobarboliniSep 20, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Theseusizes are very ambiguous. Is this the index of the column? We should document it.

EDIT: or even convert it into something along the lines of:

FromSql{column_index: usize,}

levkkand others added2 commitsSeptember 20, 2025 06:58
Co-authored-by: Paolo Barbolini <paolo@paolo565.org>
Co-authored-by: Paolo Barbolini <paolo@paolo565.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@paolobarbolinipaolobarbolinipaolobarbolini requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@levkk@BaptisteRoseau@Aceeri@paolobarbolini
[8]ページ先頭
©2009-2025 Movatter.jp