Fix transaction not being rolled back on`TransactionBuilder::start()Future` dropped before completion#1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Closed

Conversation

Copy link

Fixes the same issue as described in the#834, but for aTransactionBuilder::start()Future.

Fix transaction not being rolled back on `TransactionBuilder::start()…

fab4b18

…` `Future` dropped before completion

sfackler reviewed

		}

		Ok(Transaction::new(self))
		Transaction::begin(self).await

Copy link

Collaborator

The reason will be displayed to describe this comment to others.Learn more.

I think it'd be simpler to just have this callself.transaction_builder().start().await and have the cancellation logic in one place.

sfackler mentioned this pull request

Merged

sfackler closed this in #1162

None yet