Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

usesplit_once instead ofsplit to parse lsn strings#1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

laxjesse
Copy link
Contributor

str::split allocates a vector and generates considerably more instructions when compiled thanstr::split_once.

u64::from_str_radix(split_lo, 16) will error if thelsn_str contains more than one/ so this change should result in the same behavior as the current implementation despite not explicitly checking this.

[`str::split`](https://doc.rust-lang.org/std/primitive.str.html#method.split)allocates a vector and generates considerably more instructions when compiledthan [`str::split_once`](https://doc.rust-lang.org/std/primitive.str.html#method.split_once).[`u64::from_str_radix(split_lo, 16)`](https://doc.rust-lang.org/std/primitive.u64.html#method.from_str_radix)will error if the `lsn_str` contains more than one `/` so this change shouldresult in the same behavior as the current implementation despite not explicitlychecking this.
@sfackler
Copy link
Collaborator

Thanks! The CI failure is unrelated - I'll fix that later.

laxjesse reacted with thumbs up emoji

@sfacklersfackler merged commite528e01 intorust-postgres:masterMar 13, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@laxjesse@sfackler

[8]ページ先頭

©2009-2025 Movatter.jp