Commit9743630

committed

usesplit_once instead ofsplit to parse lsn strings

[`str::split`](https://doc.rust-lang.org/std/primitive.str.html#method.split)allocates a vector and generates considerably more instructions when compiledthan [`str::split_once`](https://doc.rust-lang.org/std/primitive.str.html#method.split_once).[`u64::from_str_radix(split_lo, 16)`](https://doc.rust-lang.org/std/primitive.u64.html#method.from_str_radix)will error if the `lsn_str` contains more than one `/` so this change shouldresult in the same behavior as the current implementation despite not explicitlychecking this.

1 parent270a29b commit9743630Copy full SHA for 9743630

File tree

+14

-10

lines changed

+14

-10

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,11 @@`
`1`	`1`	`#Change Log`
`2`	`2`
	`3`	`+##Unreleased`
	`4`	`+`
	`5`	`+###Changed`
	`6`	`+`
	`7`	+*`FromStr` implementation for`PgLsn` no longer allocates a`Vec` when splitting an lsn string on it's`/`.
	`8`	`+`
`3`	`9`	`##v0.2.6 - 2023-08-19`
`4`	`10`
`5`	`11`	`###Fixed`

Lines changed: 8 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,16 +33,14 @@ impl FromStr for PgLsn {`
`33`	`33`	`typeErr =ParseLsnError;`
`34`	`34`
`35`	`35`	`fnfrom_str(lsn_str:&str) ->Result<Self,Self::Err>{`
`36`		`-let split:Vec<&str> = lsn_str.split('/').collect();`
`37`		`-if split.len() ==2{`
`38`		`-let(hi, lo) =(`
`39`		`- u64::from_str_radix(split[0],16).map_err(\|_\|ParseLsnError(()))?,`
`40`		`- u64::from_str_radix(split[1],16).map_err(\|_\|ParseLsnError(()))?,`
`41`		`-);`
`42`		`-Ok(PgLsn((hi <<32) \| lo))`
`43`		`-}else{`
`44`		`-Err(ParseLsnError(()))`
`45`		`-}`
	`36`	`+letSome((split_hi, split_lo)) = lsn_str.split_once('/')else{`
	`37`	`+returnErr(ParseLsnError(()));`
	`38`	`+};`
	`39`	`+let(hi, lo) =(`
	`40`	`+ u64::from_str_radix(split_hi,16).map_err(\|_\|ParseLsnError(()))?,`
	`41`	`+ u64::from_str_radix(split_lo,16).map_err(\|_\|ParseLsnError(()))?,`
	`42`	`+);`
	`43`	`+Ok(PgLsn((hi <<32) \| lo))`
`46`	`44`	`}`
`47`	`45`	`}`
`48`	`46`

Comments

(0)