Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use reexported postgres for NoTls in examples#24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sfackler merged 2 commits intorust-postgres:masterfromdpetersen:reexported-postgres
Nov 8, 2020
Merged

Use reexported postgres for NoTls in examples#24

sfackler merged 2 commits intorust-postgres:masterfromdpetersen:reexported-postgres
Nov 8, 2020

Conversation

dpetersen
Copy link
Contributor

As we just discussed in#23. Rather than a big warning in theREADME about specific versions of the Postgres library which you'd have to remember to manually update, I just made the examples use the reexported library as you suggested.

I removed theuse postgres::Client since that wasn't actually getting used in the example and was generating a warning.

@dpetersen
Copy link
ContributorAuthor

It's weird thatcargo test is failing on Circle, since I did run it and it's passing locally. Good to see my superpower of breaking CI still works on a Saturday.

@sfackler
Copy link
Collaborator

CI is running against 1.40, which I'd guess is too old for that version of subtle. It looks like you should just need to bump that to 1.41.0:https://github.com/dalek-cryptography/subtle/blob/master/.travis.yml#L16

subtle was failing on 1.40, then postgres-protocol was failing on 1.41.
@dpetersen
Copy link
ContributorAuthor

Ah, that makes since. I installed 1.40.0 locally (rustup is awesome) and replicated the issue, then bumped locally. And immediately got this failure:

error[E0658]: use of unstable library feature 'matches_macro'                                                     --> /home/dpetersen/.cargo/registry/src/github.com-1ecc6299db9ec823/postgres-protocol-0.5.3/src/authentication/sasl.rs:333:29                                                                                                  |                                                                                                          333 |         self.take_while(|c| matches!(c, '\x21'..='\x2b' | '\x2d'..='\x7e'))                                  |                             ^^^^^^^                                                                          |                                                                                                              = note: for more information, see https://github.com/rust-lang/rust/issues/65721

Looked that up and it was stabilized in 1.42, so bumped to that and we're green.

@sfacklersfackler merged commit2157bb7 intorust-postgres:masterNov 8, 2020
@sfackler
Copy link
Collaborator

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dpetersen@sfackler
[8]ページ先頭
©2009-2025 Movatter.jp