Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork175
[STALE] Add Service Binding, DHCP4, IP4 Config2, HTTP, and TLS Config Protocols#952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
ben-krieger wants to merge7 commits intorust-osdev:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Hey, nice, thanks for the contribution! I probably don't have the time to look into this soon, but nevertheless it's a good starting point for someone other to polish the MR a bit and then merge it eventually |
This was referencedDec 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
As part of a private project, I needed additional network protocols, so I added these bindings. The private project has shifted in scope a bit, so I never got around to cleaning this work up. However, I wanted to make sure to at least open a PR in case this work was of use to someone else and they wished to either take on completing the higher level (above uefi-raw) impls or wished to accept it as is: working, but somewhat incomplete.
(Specifically, the raw FFI bindings to C are complete, but the higher level protocols using Rust types in the uefi package do not make use of all the lower protocol functions.)
You may also wish to separate out the first two commits, which deal with Service Binding protocol. This was necessary to implement network protocols, but is technically separate and involves a complex set of changes to, including a proc macro.
This has been tested mainly with QEMU+OVMF.
Steps to Undraft
Checklist