Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork182
uefi: Add device path generation for discovered devices in a PciTree#1831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
seijikun wants to merge4 commits intorust-osdev:mainChoose a base branch fromseijikun:mr-pci-device_paths
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ab46f2d to582714aCompare582714a to6f6f35bCompare…ation- Refactored return type from standard BTreeSet to custom PciTree struct- Removed special FullPciIoAddress type, since segment number is PciRoot dependent- During enumeration, skip branches we have already seen- During enumeration, collect tree topology information (which child bus linked from where)- Add complicated pci structure in integration test vm- Print child busses for every device entry in integration test
6f6f35b to8a4ab00CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Initial implementation for device path generation of discovered pci devices in a
PciTreeinstance.Unfortunately, it's a bit clunky to use, since you have to query the
DevicePathcorresponding to yourPciRootBridgeIoinstance yourself and pass that in:I tried getting the
DevicePathof thePciRootBridgeIoinstance withinPciRootBridgeIo::enumerate()and pass that on to thePciTree, but I couldn't find a way to get theDevicePathinstance - other than ugly workarounds.Best consumed Commit-By-Commit. Contains#1830..
Steps to Undraft
Checklist