Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork175
rust: edition 2024#1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
rust: edition 2024#1586
Uh oh!
There was an error while loading.Please reload this page.
Conversation
4719df1
toc0a9cd1
Comparephip1611 commentedMar 23, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@nicholasbishop I have a never ending back-and-forth between code gen and formatting with these lines and I don't really understand where the root cause is. Using full-text search, I can't find anything. Any idea? diff --git a/uefi-raw/src/protocol/device_path/device_path_gen.rs b/uefi-raw/src/protocol/device_path/device_path_gen.rsindex 9914779c..825a2792 100644--- a/uefi-raw/src/protocol/device_path/device_path_gen.rs+++ b/uefi-raw/src/protocol/device_path/device_path_gen.rs@@ -10,7 +10,7 @@ #![allow(missing_debug_implementations)] use crate::protocol::device_path; use crate::table::boot::MemoryType;-use crate::{guid, Guid, IpAddress};+use crate::{Guid, IpAddress, guid}; use bitflags::bitflags; use device_path::DevicePathProtocol as DevicePathHeader; #[cfg(doc)]diff --git a/uefi/src/proto/device_path/device_path_gen.rs b/uefi/src/proto/device_path/device_path_gen.rsindex 915e1ff6..3892524b 100644--- a/uefi/src/proto/device_path/device_path_gen.rs+++ b/uefi/src/proto/device_path/device_path_gen.rs@@ -15,7 +15,7 @@ use crate::proto::device_path::{ self, DevicePathHeader, DevicePathNode, DeviceSubType, DeviceType, NodeConversionError, }; use crate::proto::network::IpAddress;-use crate::{guid, Guid};+use crate::{Guid, guid}; use bitflags::bitflags; use core::mem::{size_of, size_of_val}; use core::ptr::addr_of;@@ -3647,10 +3647,10 @@ impl TryFrom<&DevicePathNode> for DevicePathNodeEnum<'_> { /// Build device paths from their component nodes. pub mod build { use super::*;+ use crate::CStr16; use crate::proto::device_path::build::{BuildError, BuildNode}; use crate::proto::device_path::{DeviceSubType, DeviceType};- use crate::CStr16;- use core::mem::{size_of_val, MaybeUninit};+ use core::mem::{MaybeUninit, size_of_val}; /// Device path build nodes for [`DeviceType::END`]. pub mod end { use super::*; |
Interesting. I'm not surewhy this is happening, but explicitly passing diff --git a/xtask/src/device_path/util.rs b/xtask/src/device_path/util.rsindex 59cdc662..e1b9fe4e 100644--- a/xtask/src/device_path/util.rs+++ b/xtask/src/device_path/util.rs@@ -16,6 +16,7 @@ pub fn is_doc_attr(attr: &Attribute) -> bool { pub fn rustfmt_string(input: String) -> Result<String> { let mut child = Command::new("rustfmt") .args([+ "--style-edition=2024", "--config", // Convert `#[doc = "..."]` to `///` for readability. "normalize_doc_attributes=true", It seems as though it's ignoring the config file, but I'm not sure why that would be. |
phip1611 commentedMar 24, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ahh, got it. I deleted |
rust: fix unsafe entry attribute
We can delete rustfmt.toml as the style version defaults tothe crate's rust edition.
phip1611 commentedMay 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Are we good to go here,@nicholasbishop? I'm not sure how to handle the Miri error 🤔 |
b8f137d
tod9e1f0a
Comparephip1611 commentedMay 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Oh interesting, miri error might be unrelated to this PR, also happens here:https://github.com/rust-osdev/uefi-rs/actions/runs/15084802709/job/42405995121 Update: contextrust-lang/miri#4323 |
8ecb54d
Uh oh!
There was an error while loading.Please reload this page.
Closes#1584
Checklist