Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Merge release-v0.30 branch into main#1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicholasbishop merged 6 commits intorust-osdev:mainfromphip1611:foo
Aug 6, 2024

Conversation

phip1611
Copy link
Member

It is weird that we have a release v0.30 branch and a released version, butuefi is still
at0.29 on the main branch. This merges the branch from#1285 into main with some necessary adaptions.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See theRewriting History guide for help.
  • Update the changelog (if necessary)

nicholasbishopand others added6 commitsAugust 2, 2024 11:19
The missing lifetime means that the &[u8] buffer could be freed while the&DevicePath still exists, which is UB.(cherry picked from commita9e48c2)
This release contains a cherry-pick ofrust-osdev#1282.
Update transitive libs.
@phip1611
Copy link
MemberAuthor

phip1611 commentedAug 6, 2024•
edited
Loading

Generally, I think the approach you have taken is valid. But I think, we should merge the changes into main as well. It feels more consistent and streamlined, doesn't it?@nicholasbishop

@nicholasbishop
Copy link
Member

Yep, I didn't think about the main branch but this definitely makes sense.

@nicholasbishopnicholasbishop added this pull request to themerge queueAug 6, 2024
Merged via the queue intorust-osdev:main with commitd4ae463Aug 6, 2024
13 checks passed
@phip1611phip1611 deleted the foo branchAugust 6, 2024 15:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicholasbishopnicholasbishopnicholasbishop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@phip1611@nicholasbishop
[8]ページ先頭
©2009-2025 Movatter.jp