Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

clippy: add use_self and const fn#1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
phip1611 merged 3 commits intorust-osdev:mainfromphip1611:clippy
Jul 31, 2024
Merged

Conversation

phip1611
Copy link
Member

Follow-up of#546, which addsconst to more functions, adds it as mandatory lint, and also usesSelf where possible.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See theRewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611phip1611force-pushed theclippy branch 4 times, most recently fromdc74b95 toe49fb4fCompareJuly 30, 2024 07:32
This has the benefit that users clearly see that no side effects can happen.However, the public API changes in the sense that once we remove const for afunction, user code might break.Nevertheless, this is a code improvement, IMHO.Regarding the device path code, which is generated: So far the simplest solutionis to deactivate this lint there. It is not trivial to decide which function canbe const and which not during code generation. It is future work to solve this,if necessary.
@phip1611phip1611 added this pull request to themerge queueJul 31, 2024
Merged via the queue intorust-osdev:main with commit7d61816Jul 31, 2024
12 checks passed
@phip1611phip1611 deleted the clippy branchJuly 31, 2024 09:07
@phip1611phip1611 mentioned this pull requestJul 31, 2024
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicholasbishopnicholasbishopnicholasbishop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@phip1611@nicholasbishop

[8]ページ先頭

©2009-2025 Movatter.jp