Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork175
clippy: add use_self and const fn#1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
dc74b95
toe49fb4f
CompareUh oh!
There was an error while loading.Please reload this page.
70e1393
to7164113
Comparenicholasbishop approved these changesJul 31, 2024
This has the benefit that users clearly see that no side effects can happen.However, the public API changes in the sense that once we remove const for afunction, user code might break.Nevertheless, this is a code improvement, IMHO.Regarding the device path code, which is generated: So far the simplest solutionis to deactivate this lint there. It is not trivial to decide which function canbe const and which not during code generation. It is future work to solve this,if necessary.
Merged via the queue intorust-osdev:main with commitJul 31, 2024
7d61816
12 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of#546, which adds
const
to more functions, adds it as mandatory lint, and also usesSelf
where possible.Checklist