Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

boot: Add freestanding version of open_protocol#1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
phip1611 merged 1 commit intomainfrombishop-free-open-proto
Jul 30, 2024

Conversation

nicholasbishop
Copy link
Member

This comes with its own version of theScopedProtocol struct. This one has noBootServices reference and no lifetime param.

For test coverage, updatedtest_uninstall_protocol_interface to useboot::open_protocol instead of theBootServices method. TheBootServices method still has plenty of coverage in the test runner sinceBootServices::open_protocol_exclusive callsBootServices::open_protocol, and the former is called in lots of places.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See theRewriting History guide for help.
  • Update the changelog (if necessary)

This comes with its own version of the `ScopedProtocol` struct. This one has no`BootServices` reference and no lifetime param.For test coverage, updated `test_uninstall_protocol_interface` to use`boot::open_protocol` instead of the `BootServices` method. The `BootServices`method still has plenty of coverage in the test runner since`BootServices::open_protocol_exclusive` calls `BootServices::open_protocol`, andthe former is called in lots of places.
@phip1611phip1611 added this pull request to themerge queueJul 30, 2024
Merged via the queue intomain with commit1f8cdfcJul 30, 2024
15 checks passed
@phip1611phip1611 deleted the bishop-free-open-proto branchJuly 30, 2024 06:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@phip1611phip1611phip1611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@nicholasbishop@phip1611
[8]ページ先頭
©2009-2025 Movatter.jp