Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork175
Finalize memory_map module refactoring#1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
81ff83f
to0fe7e51
CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
b8d9455
to2cf74f9
CompareReady for the next review-round. I incorporated your feedback into the MR. Further, I split one commit into two for better review-ability. |
78b260d
to4db0433
CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There is no public constructor for MemoryMapOwned, as the construction of it isquite complicated and therefore hidden behind BootServices::memory_map() respectivelySystemTable::exit_boot_services.The real-world use case for the public constructors for the other types is whenparsing the UEFI memory map from kernels after a bootloader, such as GRUB or Limine,passed the UEFI memory map via the corresponding boot information.
Simplify MemoryMapOwned::from_initialized_mem to simplify and streamline theconstruction in unit tests.
Add a test that imitates how a public API user would utilize our abstractions toparse a chunk of memory as UEFI memory map.
f2ace36
Uh oh!
There was an error while loading.Please reload this page.
This is (hopefully) the final step of our recent refactorings for the new
memory_map
module and all its traits and implementations. I think we are now in good shape to cover a variety of use-cases. Code inconsistencies are resolved, code structure has improved, documentation is comprehensive. Anything missing? Any comments?Thiscloses#1247.
Checklist