Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Finalize memory_map module refactoring#1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicholasbishop merged 8 commits intorust-osdev:mainfromphip1611:memory-map
Jul 30, 2024

Conversation

phip1611
Copy link
Member

This is (hopefully) the final step of our recent refactorings for the newmemory_map module and all its traits and implementations. I think we are now in good shape to cover a variety of use-cases. Code inconsistencies are resolved, code structure has improved, documentation is comprehensive. Anything missing? Any comments?

Thiscloses#1247.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See theRewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611phip1611 self-assigned thisJul 28, 2024
@phip1611phip1611force-pushed thememory-map branch 7 times, most recently from81ff83f to0fe7e51CompareJuly 28, 2024 09:05
@phip1611phip1611force-pushed thememory-map branch 2 times, most recently fromb8d9455 to2cf74f9CompareJuly 30, 2024 06:06
@phip1611
Copy link
MemberAuthor

Ready for the next review-round. I incorporated your feedback into the MR. Further, I split one commit into two for better review-ability.

@phip1611phip1611force-pushed thememory-map branch 2 times, most recently from78b260d to4db0433CompareJuly 30, 2024 06:11
There is no public constructor for MemoryMapOwned, as the construction of it isquite complicated and therefore hidden behind BootServices::memory_map() respectivelySystemTable::exit_boot_services.The real-world use case for the public constructors for the other types is whenparsing the UEFI memory map from kernels after a bootloader, such as GRUB or Limine,passed the UEFI memory map via the corresponding boot information.
Simplify MemoryMapOwned::from_initialized_mem to simplify and streamline theconstruction in unit tests.
Add a test that imitates how a public API user would utilize our abstractions toparse a chunk of memory as UEFI memory map.
@nicholasbishopnicholasbishop added this pull request to themerge queueJul 30, 2024
Merged via the queue intorust-osdev:main with commitf2ace36Jul 30, 2024
12 checks passed
@phip1611phip1611 deleted the memory-map branchJuly 30, 2024 16:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicholasbishopnicholasbishopnicholasbishop approved these changes

Assignees

@phip1611phip1611

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MemoryMapRef/MemoryMapRefMut constructors
2 participants
@phip1611@nicholasbishop

[8]ページ先頭

©2009-2025 Movatter.jp