Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test-runner: Drop the memory map OOM loop#1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

nicholasbishop
Copy link
Member

The loop makes the test runner noticably slower to run. That doesn't matter so much for CI, but is a little inconvenient for local testing.

The drop impl forMemoryMapBackingMemory is no longer conditional, so it's not particularly different from the many other types that internally allocate.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See theRewriting History guide for help.
  • Update the changelog (if necessary)

The loop makes the test runner noticably slower to run. That doesn't matter somuch for CI, but is a little inconvenient for local testing.The drop impl for `MemoryMapBackingMemory` is no longer conditional, so it's notparticularly different from the many other types that internally allocate.
@phip1611phip1611 added this pull request to themerge queueJul 21, 2024
Merged via the queue intorust-osdev:main with commitf92576dJul 21, 2024
12 checks passed
@nicholasbishopnicholasbishop deleted the bishop-drop-memloop branchJuly 21, 2024 17:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@nicholasbishop@phip1611

[8]ページ先頭

©2009-2025 Movatter.jp