Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork175
uefi: mem: mem.rs -> mem/mod.rs#1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Not sure where all of a sudden that CI failure originates from,@nicholasbishop. |
Interesting, looks like changing the order of
In
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm % updating the test expectations
This is a preliminary measurement to move the types for the uefi memory map (et al.)from the boot services module to this module.
Streamline the order of different statements.1. extern crates2. public modules3. private modules4. public uses5. private useFrom my year-long experience, it is usually a better structure to group all `use`and all `mod` statements in a file. However, it is a matter of taste if `mod`or `use` comes first.
The unit tests for the compiler diagnostics are utilizing the trybuild crate.With the recent reordering of the public exports of uefi/lib.rs, the fully qualifiedpaths have changed.To update the expected error messages, I ran:`$ TRYBUILD=overwrite cargo xtask test`I'm not sure whether the previous changes also change something observable by the publicAPI. In the Rust reference, I couldn't find anything about the fully qualified path and howit is influenced by the order of public exports.
54f7fa2
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Preliminary step for the refactoring request mentioned in#1240 (comment).
Is this the direction you were thinking about? I'd add a
uefi/mem/memory_map/{mod, ...}.rs
in a next step and addpub
re-exports in the old location with a deprecation note.Checklist