Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork175
runtime: Add freestanding functions to get/set/delete UEFI variables#1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
698b597
to5cbdb12
CompareThis will allow `make_boxed` to be used in `get_variable_boxed`.
5cbdb12
to800af86
CompareThe new version of `get_variable` returns the required size in the error data ifthe input buffer is too small. This allows `get_variable_boxed` to use`make_boxed`, and also makes `get_variable_size` unnecessary.Also added more info about errors to the docstrings.(Note: `variable_keys` function to come in a later commit.)
800af86
to3fe8b6b
Comparephip1611 approved these changesJul 21, 2024
Merged via the queue intomain with commitJul 21, 2024
23eb0e8
15 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version of
get_variable
returns the required size in the error data if the input buffer is too small. This allowsget_variable_boxed
to usemake_boxed
, and also makesget_variable_size
unnecessary.Also:
Align
for[u8]
to allowmake_boxed
to work here.(Note:
variable_keys
function to come in a later PR.)Checklist