NotificationsYou must be signed in to change notification settings
Fork175
Star1.4k

boot: Always impl Drop for MemoryMapBackingMemory#1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

phip1611 merged 1 commit intorust-osdev:mainfromnicholasbishop:bishop-mmap-drop

Jul 21, 2024

Merged

boot: Always impl Drop for MemoryMapBackingMemory#1248

phip1611 merged 1 commit intorust-osdev:mainfromnicholasbishop:bishop-mmap-drop

Jul 21, 2024

Conversation

Copy link

Member

nicholasbishop commentedJul 17, 2024

Gating this oncfg(not(test)) isn't necessary; during unit testssystem_table_boot() will returnNone and so the drop won't do anything anyway.

Also fix a typo, excited -> exited.

Checklist

Sensible git history (for example, squash "typo" or "fix" commits). See theRewriting History guide for help.
Update the changelog (if necessary)

boot: Always impl Drop for MemoryMapBackingMemory

ccf9897

Gating this on `cfg(not(test))` isn't necessary; during unit tests`system_table_boot()` will return `None` and so the drop won't do anythinganyway.Also fix a typo, excited -> exited.

phip1611 reviewed

Jul 21, 2024

View reviewed changes

uefi/src/table/boot.rs

		@@ -1747,7 +1745,7 @@ impl Drop for MemoryMapBackingMemory {
		log::error!("Failed to deallocate memory map: {e:?}");
		}
		} else {
		log::debug!("Boot services are excited. Memory map won't be freed using the UEFI boot services allocator.");