Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add PcrEvent::new_in_box/PcrEventInputs::new_in_box#1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

nicholasbishop
Copy link
Member

Fixes#780

The initial commits are modifying the structs so that themake_boxed utility can be used.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See theRewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishopnicholasbishopforce-pushed thebishop-tcg-new-boxed branch 2 times, most recently fromeb28d30 tof110e57CompareJuly 15, 2024 04:24
@nicholasbishopnicholasbishop marked this pull request as draftJuly 15, 2024 04:25
@nicholasbishop
Copy link
MemberAuthor

(Marking draft til I finish fixing errors)

This is needed for make_boxed.
This is needed for make_boxed. Technically it's slightly less efficient, sincethe input buf must now be initialized, but in practice these structs are quitesmall and not created all that often, so there's no meaningful difference.
A manual implementation is required since this is a packed struct.
@nicholasbishopnicholasbishop marked this pull request as ready for reviewJuly 15, 2024 17:20
Copy link
Member

@phip1611phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very nicely done. A great use ofmake_boxed!

@phip1611phip1611 added this pull request to themerge queueJul 16, 2024
Merged via the queue intorust-osdev:main with commit1fa9408Jul 16, 2024
12 checks passed
@nicholasbishopnicholasbishop deleted the bishop-tcg-new-boxed branchJuly 16, 2024 15:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@phip1611phip1611phip1611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PcrEventInputs alloc-only method?
2 participants
@nicholasbishop@phip1611
[8]ページ先頭
©2009-2025 Movatter.jp