NotificationsYou must be signed in to change notification settings
Fork175
Star1.4k

uefi: Fix return value lifetime for register_protocol_notify#1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

phip1611 merged 1 commit intorust-osdev:mainfromnicholasbishop:bishop-fix-lifetime

Jul 8, 2024

Merged

uefi: Fix return value lifetime for register_protocol_notify#1228

phip1611 merged 1 commit intorust-osdev:mainfromnicholasbishop:bishop-fix-lifetime

Jul 8, 2024

Conversation

Copy link

Member

nicholasbishop commentedJul 7, 2024

Due to the rules of lifetime elision
(https://doc.rust-lang.org/reference/lifetime-elision.html), the lifetime of theSearchType returned fromregister_protocol_notify was infered to be the lifetime ofSelf. The correct lifetime is theprotocol reference.

In practice this isn't likely to matter much to users, but I noticed it due to a compilation error when working on#893

Checklist

Sensible git history (for example, squash "typo" or "fix" commits). See theRewriting History guide for help.
Update the changelog (if necessary)

uefi: Fix return value lifetime for register_protocol_notify

4b564bf

Due to the rules of lifetime elision(https://doc.rust-lang.org/reference/lifetime-elision.html), the lifetime of the`SearchType` returned from `register_protocol_notify` was infered to be thelifetime of `Self`. The correct lifetime is the `protocol` reference.