Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

uefi: Stop enablingerror_in_core feature#1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicholasbishop merged 1 commit intomainfrombishop-err-in-core
Jun 10, 2024

Conversation

nicholasbishop
Copy link
Member

This should fix the CI errors.

This feature has been stabilized in latest nightly, so no need to enable it. All the uses of it (impl core::error::Error for for ...) are still gated by theunstable feature, so there's no change for users on the stable channel.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See theRewriting History guide for help.
  • Update the changelog (if necessary)

phip1611 reacted with thumbs up emoji
This feature has been stabilized in latest nightly, so no need to enable it. Allthe uses of it (`impl core::error::Error for for ...`) are still gated by the`unstable` feature, so there's no change for users on the stable channel.
@nicholasbishop
Copy link
MemberAuthor

I'll go ahead and merge this to fix CI.

@nicholasbishopnicholasbishop added this pull request to themerge queueJun 10, 2024
Merged via the queue intomain with commita59a73eJun 10, 2024
15 checks passed
@nicholasbishopnicholasbishop deleted the bishop-err-in-core branchJune 10, 2024 16:10
@phip1611
Copy link
Member

phip1611 commentedJun 11, 2024•
edited
Loading

Once this lands in rustc stable, and two more stable releases have passed (our MSRV policy), we remove the feature gate where it is no longer needed and create a new release, right?

@nicholasbishop
Copy link
MemberAuthor

Yep. Filed#1200 as a reminder.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@nicholasbishop@phip1611
[8]ページ先頭
©2009-2025 Movatter.jp